Merged
Conversation
# By Igor Minar (59) and others # Via Igor Minar (2) and others * 'master' of https://github.com/ashesi-SE/datasaver: (170 commits) chore(package.json): fix path to angular-load.min.js.map in "update-index-async" command chore(package.json): remove local HTTP server's cache-control header docs(scenarios): fix link to protractor docs docs(README): fix grammar and ambiguous sentence docs(README): fix link to Jasmine chore(package.json): update to protractor 1.1.1 refact(*): further architectural improvements refact(*): update overall application architecture to match best practices refact(*): refactor app layout to conform to best practices chore(travis): node js version should between quotes docs(README): fix typos fix(index-async): correct the path to bower_components fix(index): remove invalid path references chore(bower): move bower_components under the app folder test(controllers): provide $scope when instantiating controllers chore(bower): fix angular-mocks dependency chore(karma): add junit-reporter feat(myApp.controllers): add $scope param to clarify annotation feat(index): use html5-boilerplate HTML, modernizr and styles fix(package.json): bind web server only to localhost ...
just did this in the github interfae..
# By Todd Warren # Via Todd Warren * 'master' of https://github.com/ashesi-SE/datasaver: Created readme for winnie
Member
Comment on sourceData is still hardcoded; assume this is the database problem. come and see me comment on status reportOn database; you can either build a simple database server in php or nodejs OR you canuse a pre-built rest service like parse ( see their rest docs ). Feel free to come see me on wedenseday to talk Rubric - data saver -Score: 18/20 good score; still a little concerned about ability to trial application
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STATUS REPORT
Accomplishments
What we didn’t get done
Where we are stuck
Insights