Fix broadcast: use global i18n in wizard scenes#18
Merged
Conversation
ctx.i18n is undefined in wizard steps 2+ because setupI18N middleware runs after stage.middleware() in the chain. Wizard steps fire inside stage.middleware(), so i18n middleware never executes for them. Use the global i18n singleton with explicit language from ctx.dbuser, matching the pattern used by sceneWrapper's own error handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.i18nbeing undefined in wizard steps 2+ (causes "Unknown error" on /broadcast)setupI18Nruns afterstage.middleware()in the chain, so wizard steps never getctx.i18ni18n.t(lang, key)singleton instead, matching the pattern insceneWrapperRoot cause