Added MSVC build to workflow & Fixed MSVC build issues#109
Merged
ashvardanian merged 8 commits intoashvardanian:main-devfrom Mar 3, 2024
Merged
Added MSVC build to workflow & Fixed MSVC build issues#109ashvardanian merged 8 commits intoashvardanian:main-devfrom
ashvardanian merged 8 commits intoashvardanian:main-devfrom
Conversation
ashvardanian
approved these changes
Mar 3, 2024
Owner
|
Epic, @ashbob999! Thank you! |
ashvardanian
requested changes
Mar 3, 2024
…r debugging for test.cpp
Owner
|
Ouch. I've rushed merging and now the Windows pipeline fails. @ashbob999, any chance you known why is that? |
Contributor
Author
|
It's the iterator issue still, since you reverted it back to using begin/end and iterator debugging is enabled for release mode, it now errors. |
ashvardanian
pushed a commit
that referenced
this pull request
Mar 3, 2024
Owner
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some fixes for building with MSVC
range_(r)matches::iterator::operator==when comparing iterators from different containers in debug mode/archflags for MSVC when buildingstringzilla_test_cpp20_x86_*