OAuth token isn't being passed down

[myusuf3]

e.g when I am using the call

Github(access_token=oauthtoken) -- it seems to work fine for all calls expect, the following call

project being repo.project

commits += self.client.commits.list(str(project))

I get the follow exception

unexpected response from github.com 401: '{"error":"Couldn't authenticate you"}'

I managed to work around this issue by creating the self.client using the following instantiation

Github(self.oauthtoken)

It probably not being pass down the OAuth token on the particular call.

[JNRowe]

Without version information in your bug report I'm going to assume for now that this is the regression fixed in 82ff5d5.

If you could test this with HEAD I'd really appreciate it. If it isn't the problem fixed by 82ff5d5 could you include the actual snippet you used(minus auth keys), and the traceback you received. For example, I'm guessing that you were listing a private repository's commits but I have no way to know that from your bug report.

Thanks,

James

[myusuf3]

I will do, I will report back when I do.

[myusuf3]

running from the current head I getting the following traceback. This might be related to another issue I email you about earlier today as well.

File "/usr/local/lib/python2.6/dist-packages/django/core/handlers/base.py" in get_response

1.                     response = callback(request, _callback_args, *_callback_kwargs)
   

   File "/home/myusuf3/Github/prologger/../prologger/views.py" in analyze_achievements
2. achi = ach.get_achievements()
   File "/home/myusuf3/Github/prologger/../prologger/achievements_analytics.py" in get_achievements

3.         getattr(self, check)()
   

   File "/home/myusuf3/Github/prologger/../prologger/achievements_analytics.py" in pottymouth

4.         commits += self.client.commits.list(unicode(project))
   

   File "/usr/local/lib/python2.6/dist-packages/github2-0.3.1-py2.6.egg/github2/commits.py" in list

5.                            filter="commits", datatype=Commit)
   

   File "/usr/local/lib/python2.6/dist-packages/github2-0.3.1-py2.6.egg/github2/core.py" in get_values

6.     values = self.make_request(_args, *_kwargs)
   

   File "/usr/local/lib/python2.6/dist-packages/github2-0.3.1-py2.6.egg/github2/core.py" in make_request

7.         response = self.request.get(self.domain, command, *args)
   

   File "/usr/local/lib/python2.6/dist-packages/github2-0.3.1-py2.6.egg/github2/request.py" in get

8.     return self.make_request("/".join(path_components))
   

   File "/usr/local/lib/python2.6/dist-packages/github2-0.3.1-py2.6.egg/github2/request.py" in make_request

9.     result = self.raw_request(url, extra_post_data, method=method)
   

   File "/usr/local/lib/python2.6/dist-packages/github2-0.3.1-py2.6.egg/github2/request.py" in raw_request

10.                            response.status, content))
    

Exception Type: RuntimeError at /analyze/
Exception Value: unexpected response from github.com 401: '{"error":"Couldn't authenticate you"}'

[JNRowe]

You've still not provided the information I asked for, and I can't investigate your report without it.

Please understand that I'm not trying to be difficult, but without enough information to replicate the problem I really can't look in to it.

[myusuf3]

def pottymouth(self):
pottymouth = {'pottymouth': False}
github = Github(self.oauthtoken)
repos = github.repos.list(self.username)
commits = []
words = ['fuck', 'shit', 'piss', 'cunt', 'tits', 'motherfucker', 'cocksucker']
for repo in repos:
project = repo.project
commits += github.commits.list(project)
for commit in commits:
for word in words:
if string_found(word, unicode(commit.message)) and unicode(commit.author['login']) == self.username:
pottymouth = {'pottymouth': True}
break
else:
continue
self.achievements.update(pottymouth)

here is the code snippet that i am using to cause the issue.Github I have provided the stack trace i am running off the current head. I can confirm I wasn't listing private repos. since when i do a repos.list only return the public ones. I am seeing the same issue with the tests. I understand your not trying to be difficult. no worries

[JNRowe]

I still can't replicate it after fixing your snippet to run standalone, but I suspect the problem is caused by your OAuth application usage. Do your tokens have the correct scope(in this instance probably repo)? Default scope doesn't have read access to commits, check the GitHub documentation for the scope table.

[JNRowe]

Just checked, I can replicate your issue with an incorrectly scoped OAuth authentication token.

If this still isn't the issue, please post a usable snippet to produce the error. I may have inadvertently fixed whatever was causing it when I hacked it to work as a test case, it really is difficult to tell without all the information to reproduce it.

[myusuf3]

What other information do you require. I have provided the snippet and the traceback. I will run with head installed soon to see if you fixed the issue. I have read the bugs.rst I will try to provide the missing parts. :)

[JNRowe]

As there have been no updates on this bug I'm going to assume it was an token scope issue and close this bug, if it wasn't reopen it with a standalone snippet that exhibits the behaviour and a traceback.