Closed
Conversation
Collaborator
Author
|
The lack of timezone handling also exhibits itself for any consumers who use a timedelta to convert to local time for the duration of any gap between GitHub's switch to DST and their own. On the order of 2-4 weeks a year for regions that I personally care about ;) |
Collaborator
Author
|
First-run implementation of option 3 from above. Works, but needs some refactoring. |
Collaborator
Author
|
With the pull request merge there is a new issue of handling timezones because pull requests don't use the "GitHub timezone". |
v2.0 only works with Python 3.
Collaborator
Author
|
The mostly new commits now listed in this pull request( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feeble brainstorming session...
I've just been bitten quite badly by the lack of timezone handling, the cause is the use of naive datetime objects in the 'GitHub' timezone(
America/Los_Angeles). While processing some tasks that span the PST/PDT changeover the ordering of events is broken.Options are:
python-dateutil makes handling option 1 quite easy, and also simplifies the handling of option 3 at the cost of another external dependency. Option 2 is just pure evil, or pure stupidity depending on point of view.
Option 3 results in a parsing using something like the following entirely untested code:
And similarly producing GitHub compatible date strings would require handling of naive formats with equally untested code such as: