Skip to content

perf(adapters): isolate shared contexts by events config#166

Merged
vamgan merged 1 commit intomainfrom
fix/163-shared-observe-lifecycle
Apr 11, 2026
Merged

perf(adapters): isolate shared contexts by events config#166
vamgan merged 1 commit intomainfrom
fix/163-shared-observe-lifecycle

Conversation

@vamgan
Copy link
Copy Markdown
Collaborator

@vamgan vamgan commented Apr 11, 2026

Summary

  • reuse one shared Askable context per normalized events configuration in React and Vue
  • keep React private contexts stable across rerenders while still switching shared contexts when events changes
  • add lifecycle regression coverage for shared reuse, event isolation, and React rerender behavior
  • update package README and docs to explain the per-events sharing model

Test Plan

  • npm test
  • npm run build
  • independent code review

Closes #163

- reuse one shared observer per normalized events set
- keep private React contexts stable across rerenders
- add React/Vue lifecycle regression tests
- update package and docs references for the new sharing model

Closes #163
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 11, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@askable-ui/core@166
npm i https://pkg.pr.new/@askable-ui/react@166
npm i https://pkg.pr.new/@askable-ui/svelte@166
npm i https://pkg.pr.new/@askable-ui/vue@166

commit: 40d825f

@vamgan vamgan merged commit 353dde6 into main Apr 11, 2026
7 checks passed
@vamgan vamgan deleted the fix/163-shared-observe-lifecycle branch April 11, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(adapters): avoid repeated observe()/unobserve() churn for shared contexts

1 participant