Skip to content

Update shebang to be path-agnostic#345

Merged
nvnieuwk merged 1 commit intoaskimed:mainfrom
valterschutz:main
Mar 17, 2026
Merged

Update shebang to be path-agnostic#345
nvnieuwk merged 1 commit intoaskimed:mainfrom
valterschutz:main

Conversation

@valterschutz
Copy link

Supports NixOS. It's also what nextflow uses in their install.

Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Thanks

@nvnieuwk nvnieuwk merged commit 0eb3562 into askimed:main Mar 17, 2026
8 checks passed
@rollf
Copy link

rollf commented Mar 20, 2026

@valterschutz I appreciated your improvement. Nipkgs' nf-test does not use this shell script you changed and simply wrapes/invokes the JAR directly. Out of pure curiosity: What was your intention to change this upstream?

(I'm maintaining the nf-test nixpkgs so I'm just eager to know your use case. I could imagine that you want to develop nf-test locally.)

@valterschutz
Copy link
Author

@valterschutz I appreciated your improvement. Nipkgs' nf-test does not use this shell script you changed and simply wrapes/invokes the JAR directly. Out of pure curiosity: What was your intention to change this upstream?

(I'm maintaining the nf-test nixpkgs so I'm just eager to know your use case. I could imagine that you want to develop nf-test locally.)

Good question. I think I remember getting an error when running nf-test from nixpkgs, but sadly I don't have the details anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants