Report ComCtl SxS version (6.10) instead of Windows product version#1
Merged
Report ComCtl SxS version (6.10) instead of Windows product version#1
Conversation
Use dwFileVersion instead of dwProductVersion for comctl32.dll since the file version contains the meaningful SxS/fusion version (e.g. 6.10 for v6 themed controls, 5.82 for legacy). Other DLLs (XAML, WinUI3) continue using dwProductVersion to avoid misleading 6.2.x file versions. The ComCtl version is also truncated to major.minor since the build and revision parts aren't meaningful for SxS versioning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dwFileVersion instead of dwProductVersion for comctl32.dll since the file version contains the meaningful SxS/fusion version (e.g. 6.10 for v6 themed controls, 5.82 for legacy). Other DLLs (XAML, WinUI3) continue using dwProductVersion to avoid misleading 6.2.x file versions.
The ComCtl version is also truncated to major.minor since the build and revision parts aren't meaningful for SxS versioning.