build: enable noImplicitReturns in tsconfig to catch missing return paths#408
Merged
askpt merged 2 commits intoJun 23, 2026
Merged
Conversation
…aths Enable the noImplicitReturns strict TypeScript compiler flag so the compiler reports an error when not all code paths in a function return a value. This catches potential runtime bugs earlier at compile time. The codebase already compiles cleanly with this flag. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
=======================================
Coverage 78.17% 78.17%
=======================================
Files 13 13
Lines 4164 4164
Branches 468 468
=======================================
Hits 3255 3255
Misses 906 906
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Enables the
noImplicitReturnsTypeScript compiler flag intsconfig.json, so the compiler reports an error when not all code paths in a function return a value. This catches a common category of bugs (missingreturnon some branch) at compile time rather than at runtime.What Changed
tsconfig.json:noFallthroughCasesInSwitch(was missing, which would have caused a parse error ifnoImplicitReturnswere enabled)"noImplicitReturns": trueWhy
noImplicitReturnsis already enabled in most production TypeScript codebases. The existing codebase compiles with zero errors under this flag — enabling it costs nothing today but prevents future regressions.Test Status
No code changes required — the existing source already satisfies this constraint.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
releaseassets.githubusercontent.comSee Network Configuration for more information.
Add this agentic workflows to your repo
To install this agentic workflow, run