Conversation
onur-askui
force-pushed
the
feat/integrate-openrouter
branch
from
730310e to
d27808d
Compare
There was a problem hiding this comment.
Super well done (not overengineered, extendable for the most part and well-documented) :) Could not find any blockers from merging, only optimisations I would do for e.g., more consistency or ease of use... (could also be tackled in follow up PR so we get this out fast)
| if response_schema is not None: | ||
| error_msg = f'Response schema is not supported for model "{model_choice}"' | ||
| raise NotImplementedError(error_msg) |
There was a problem hiding this comment.
Couldn't we easily support this (see https://openrouter.ai/docs/features/structured-outputs#best-practices) by setting require_parameters to True if response_schema is not None or isinstance(response_schema, str)? I guess if the model does not support it then, it is going to raise an exception and in all other cases route to a model that supports it.
onur-askui
force-pushed
the
feat/integrate-openrouter
branch
from
2b092dd to
7a6b68d
Compare
As discussed, will address the comments in a separate PR |
2 participants
No description provided.