Skip to content

feat: support newer rules_lint#953

Closed
thesayyn wants to merge 27 commits into
mainfrom
axel-f-rules-lint
Closed

feat: support newer rules_lint#953
thesayyn wants to merge 27 commits into
mainfrom
axel-f-rules-lint

Conversation

@thesayyn
Copy link
Copy Markdown
Member

@thesayyn thesayyn commented Mar 2, 2026

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Support newest rules_lint

Test plan

  • New test cases added

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 613d3894a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread crates/axl-runtime/Cargo.toml Outdated
Comment thread crates/aspect-cli/src/builtins/aspect/lib/linting.axl Outdated
@thesayyn thesayyn force-pushed the axel-f-rules-lint branch from af74fe6 to 1942657 Compare April 6, 2026 20:10
@thesayyn
Copy link
Copy Markdown
Member Author

thesayyn commented Apr 6, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25c6742a33

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread crates/aspect-cli/src/builtins/mod.rs Outdated
Comment thread crates/aspect-cli/src/builtins/aspect/config/lint.axl Outdated
Comment thread examples/lint/MODULE.aspect Outdated
Comment thread crates/aspect-cli/src/builtins/aspect/lib/github.axl Outdated
Comment thread examples/lint/hello.sh
name=$1

# SC2086: Double quote to prevent globbing and word splitting.
# shellcheck will flag the unquoted $name below.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellCheck (error)

Couldn't parse this shellcheck directive. Fix to allow more checks.

@thesayyn thesayyn closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant