Initial example of generating ts_project #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
commented
May 1, 2022
|
|
||
| ts_project( | ||
| name = "ts_gazelle", | ||
| srcs = ["lib/foo.ts"], |
Member
Author
There was a problem hiding this comment.
@jbedard I confirmed that from userland we get the same behavior as the gazelle_generation_test: we don't ever create new BUILD files
Member
There was a problem hiding this comment.
That seems to be the case. As I understand it gazelle invokes the GenerateRules method based on which BUILDs already exist.
See the sub-directories logic which I essentially copied from python:
https://github.com/bazelbuild/rules_python/blob/0.8.1/gazelle/generate.go#L105
https://github.com/aspect-build/rules_ts/blob/2ae033f0e4ea0ec1081de67231f7c07347797d96/gazelle/generate.go#L192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, we shouldn't need deps.bzl here - but without it, I see that go_repository generates wrong BUILD files for esbuild, missing the
selectclauses indepsfororg_golang_x_sys. Seems like a bug in gazelle.