feat: add rules_py example using ipython shell #8
Conversation
| @@ -0,0 +1,50 @@ | |||
| workspace(name = "rules_py_ipython_example") | |||
There was a problem hiding this comment.
so far our convention in other Aspect rulesets has been that nested workspaces are under an e2e/ folder, and are just meant to protect us from bugs (minimal commenting and content)
User-facing examples are in the examples/ folder and rely on the root WORKSPACE file.
I know we've had a few different iterations on this. It's nice that you can just bazel test ... from the root here and cover all the examples
There was a problem hiding this comment.
Then write_source_files doesn't conform to this?
https://github.com/aspect-build/bazel-examples/tree/main/write_source_files
It's nice that you can just bazel test ... from the root here
"here" being this repo, or the rule set? As a lot of the examples in this repo have their own WORKSAPCE etc, so bazel test ... at the root of this repo would kinda do nothing.
| @@ -0,0 +1,3 @@ | |||
| from IPython import start_ipython | |||
|
|
|||
| start_ipython() | |||
There was a problem hiding this comment.
is it possible for a py_binary entrypoint to run ipython without having to add this shim?
|
If ts gazelle is in rules_ts, then this should be in the e2e folder too? #4 Not trying to nit pick, I'm just not understanding the separation with what is going / already in here and the intended use. |
|
let's chat about them - I'm sure we aren't consistent across rulesets. the bazel-examples repo is special since the whole thing is one big e2e - there are only nested WORKSPACEs |
|
Reopened this in aspect-build/rules_py#28 |
Initial example of using rules_py. Planning to add a Django example as that has more moving parts, but this is simple case, and provides an interactive
ipythonshell.