fix: ensure transitive wheels are passed from py_library #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Apr 18, 2022
| has_py3_only_sources = True, | ||
| uses_shared_libraries = False, | ||
| ), | ||
| py_wheel_info, |
Member
There was a problem hiding this comment.
nit: any reason not to inline the variable declaration?
Collaborator
Author
There was a problem hiding this comment.
No reason other than personal preference
mattem
force-pushed
the
fix/transitive_wheels
branch
2 times, most recently
from
577285c to
adaf1e0
Compare
alexeagle
approved these changes
Apr 18, 2022
mattem
force-pushed
the
fix/transitive_wheels
branch
from
adaf1e0 to
e926a5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4