Skip to content

Clean up all symlinks in venv #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

Clean up all symlinks in venv #112

merged 2 commits into from
Jan 5, 2023

Conversation

@mvukov
Copy link
Contributor

@mvukov mvukov commented Dec 12, 2022

Cleans up all symlinks in generated venv. This needs to happen such that remote caching works properly when --remote_download_minimal or --remote_download_toplevel are used.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mvukov
Copy link
Contributor Author

mvukov commented Dec 12, 2022

@mattem PTAL.

@mattem mattem enabled auto-merge (squash) January 5, 2023 00:43
@mattem mattem merged commit 540eef1 into aspect-build:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattem mattem mattem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvukov @CLAassistant @mattem