Fix/repo relative imports #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mattem @alexeagle PTAL. |
Collaborator
|
I'm still not sure on making this implicit, and would rather it be explicitly added to a rules |
mattem
reviewed
Jan 6, 2023
Contributor
Author
Well, that's how official Bazel rules behave. FWIW, in a monorepo setting folks typically import their Python modules in a repo-relative fashion. And, from what I know, that works out of the box with the official rules. @mattem PTAL. |
Contributor
Author
|
@mattem friendly ping. PTAL when you have time. |
1 similar comment
Contributor
Author
|
@mattem friendly ping. PTAL when you have time. |
mattem
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94 . The extra import path is routed via the .pth file.