fix: set shebang directly instead of via sh_toolchain #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Apr 28, 2022
Member
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
I think you should still declare the sh toolchain as a dependency... though I am not sure why
mattem
force-pushed
the
fix/sh_toolchain
branch
from
67827d7 to
ec45fdf
Compare
alexeagle
reviewed
May 2, 2022
| load("//py/private/venv:venv.bzl", _py_venv = "py_venv_utils") | ||
|
|
||
| def _py_binary_rule_imp(ctx): | ||
| bash_bin = ctx.toolchains[SH_TOOLCHAIN].path |
Member
There was a problem hiding this comment.
feels like we should leave a comment - I'm not that confident we've got it correct yet. this might just be a workaround for RBE not having the bash toolchain defined.
alexeagle
approved these changes
May 2, 2022
Collaborator
Author
|
I'm not convinced this is the right thing, so I'm going to close this. If someone convinces me that this is right fix, rather than registering the right toolchain on RBE, then we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #12 (comment)