feat: create venv in a separate action #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
force-pushed
the
feat/venv_action
branch
4 times, most recently
from
1f5512c to
6e286df
Compare
alexeagle
reviewed
Apr 26, 2022
mattem
force-pushed
the
feat/venv_action
branch
from
6e286df to
86839a7
Compare
alexeagle
approved these changes
Apr 27, 2022
gregmagolan
reviewed
Apr 27, 2022
gregmagolan
reviewed
Apr 27, 2022
gregmagolan
reviewed
Apr 27, 2022
| WHL_REQUIREMENTS_FILE=$(maybe_rlocation "{{WHL_REQUIREMENTS_FILE}}") | ||
|
|
||
| # Convenience vars for the Python virtual env that's created. | ||
| VENV_LOCATION="{{VENV_LOCATION}}" |
Member
There was a problem hiding this comment.
hmm. perhaps make the substitutions lowercase so they are easier to differentiate from the bash vars when reading this?
VENV_LOCATION="{{venv_location}}"
86839a7 to
4b47f00
Compare
mattem
force-pushed
the
feat/venv_action
branch
from
4b47f00 to
1f467b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
The virtual env is now created in an action and passed back into the runfiles. There are a few hoops to jump through because of this, mainly around dealing with pathing changes and bazel validating files (symlinks) within tree artifacts.
This should speed up running binaries and tests as changes to first party sources won't cause the venv to get recreated on each run.
For the IDE,
bazel run //py/tests/external-deps:main.venvwill create a virtual env for the target under{BUILD_WORKSPACE_DIRECTORY}/.{name}.venv. As a follow up, it would be nice to allow changing the path to the venv, but this is likely fine for now.