feat: py_image_layers #349
Conversation
alexeagle
force-pushed
the
py_image_layer
branch
from
9aa43f9 to
93bd381
Compare
|
Please provide a description of the change rather than just a link to an issue. |
mattem
left a comment
mattem
left a comment
There was a problem hiding this comment.
As this is becoming public API, please add tests.
| # match *only* external pip like repositories that contain the string "site-packages" | ||
| SITE_PACKAGES_REGEX = "\\.runfiles/.*/site-packages/.*" | ||
|
|
||
| def py_image_layers(name, binary, interpreter_regex = PY_INTERPRETER_REGEX, site_packages_regex = SITE_PACKAGES_REGEX): |
There was a problem hiding this comment.
Pass kwargs and propagate the well known tags.
| name = "say_image", | ||
| base = "@ubuntu", | ||
| entrypoint = ["/examples/py_binary/say_hello"], | ||
| tars = py_image_layers("say_image_layers", "say_hello"), |
There was a problem hiding this comment.
Could this instead produce a filegroup, so it can be used like a regular rule, rather than unexpectedly returning a list?
|
|
||
| register_coreutils_toolchains() | ||
|
|
||
| register_tar_toolchains() |
There was a problem hiding this comment.
Users will also need this toolchain? Is the expectation that they register too, or should this ruleset be doing that in the setup
| mtree = "{}.{}_tar_manifest".format(name, layer), | ||
| ) | ||
|
|
||
| return result |
There was a problem hiding this comment.
native.filegroup(
name = name,
srcs = results,
... tags, visibility, etc.
)
| # match *only* external pip like repositories that contain the string "site-packages" | ||
| SITE_PACKAGES_REGEX = "\\.runfiles/.*/site-packages/.*" | ||
|
|
||
| def py_image_layers(name, binary, interpreter_regex = PY_INTERPRETER_REGEX, site_packages_regex = SITE_PACKAGES_REGEX): |
There was a problem hiding this comment.
interpreter_regex and site_packages_regex are unused, the constants are used in the macro below, did you mean to use them?
Replaces #349 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Add `py_image_layer` macro for creating py container images. ### Test plan I will add a test in a follow-up.
Fixes #212
Changes are visible to end-users: yes
A helper function to create image layers for a
py_binaryis now included.Test plan