fix(activate): Don't set PYTHONEXECUTABLE #699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Paired with @alexeagle. It used to be before recent improvements to runfiles tree identification and the venv shim that we relied on the activate script to set PYTHONEXECUTABLE. This proved to be unreliable, in part because many tools just don't evaluate the activate script.
Setting the PYTHONEXECUTABLE without also setting PYTHONHOME breaks non-Bazel Python invocations and so is a bug. Furthermore we didn't save/restore or more importantly unset PYTHONEXECUTABLE during deactivate, which broke shell environments.
Just don't set this.
Fixes #671.
Changes are visible to end-users: yes
Fixed #671,
activatescripts no longer poison the shell env.Test plan