Skip to content

Conversation

@dzbarsky
Copy link
Collaborator

@dzbarsky dzbarsky commented Nov 23, 2025

skylib's implementation of config_setting_group is a little wild, it generates chains of selects and alias targets. We don't really need to do that, we can just declare what we want directly.

bazel query //uv/private/constraints/platform:all | wc -l drops from 12K to 5.3K. All the removed targets were private so feels like this should be fine.

Also:

before:
image

after:
image


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@dzbarsky dzbarsky requested a review from arrdem November 23, 2025 18:17
@aspect-workflows
Copy link

aspect-workflows bot commented Nov 23, 2025

test-os:linux-bzl:8 (Test)

All tests were cache hits

38 tests (100.0%) were fully cached saving 50s.


test-os:linux-bzl:latest (Test)

All tests were cache hits

38 tests (100.0%) were fully cached saving 50s.


test-os:linux-bzl:8 (Test)

e2e

All tests were cache hits

14 tests (100.0%) were fully cached saving 10s.


test-os:linux-bzl:latest (Test)

e2e

All tests were cache hits

14 tests (100.0%) were fully cached saving 10s.


test-os:linux-bzl:8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.


test-os:linux-bzl:latest (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.

@dzbarsky dzbarsky force-pushed the zbarsky/optimize_constraints branch from bc23550 to a910638 Compare November 23, 2025 19:07
@arrdem
Copy link
Collaborator

arrdem commented Nov 25, 2025

Ah nice. We can probably apply the same optimization to the interpreter range and ABI tests.

@dzbarsky
Copy link
Collaborator Author

Ah nice. We can probably apply the same optimization to the interpreter range and ABI tests.

Sure I can look at those in a follow-up

@arrdem arrdem merged commit 601612a into main Nov 25, 2025
5 checks passed
@arrdem arrdem deleted the zbarsky/optimize_constraints branch November 25, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants