Generate fewer targets for platform constraints #727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

skylib's implementation of
config_setting_groupis a little wild, it generates chains of selects and alias targets. We don't really need to do that, we can just declare what we want directly.bazel query //uv/private/constraints/platform:all | wc -ldrops from 12K to 5.3K. All the removed targets were private so feels like this should be fine.Also:
before:

after:

Changes are visible to end-users: no
Test plan