Draft
Conversation
|
Collaborator
Author
|
Blocked on #776 probably. |
a3cdf70 to
912d5e6
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


We still can't really support windows. But. We can fix windows-only wheels producing build graphs.
This PR makes two related changes here.
First it ensures that we will never produce an empty selection chain by ensuring that it will always end with an incompatible dummy target, which fixes #754.
Second we add stub Windows platform configuration flags and adjust the wheel filtering to allow for windows.
The net effect here is that although we cannot currently perform windows whl installs due to lack of appropriate interpreters, we can configure the build graph as it would need to be and avoid the analysis errors reported in #754.
Fixes #754.
Changes are visible to end-users: yes
FIXME
Test plan
FIXME