Conversation
Adds an e2e test case exercising pytest-mock with both py_test (pytest_main=True) and py_venv_test. Confirms the mocker fixture, mocker.spy, and MagicMock all work correctly. Closes #530 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
arrdem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest-mock works correctly with both
py_test(usingpytest_main=True) andpy_venv_teston current main. The original issue was likely a configuration problem — either using@pypi//pytest-mock(hyphen, doesn't exist) instead of@pypi//pytest_mock(underscore), or not includingpytest-mockin the project'spyproject.tomldependencies.This adds an e2e regression test to make sure it stays working.
Closes #530
Changes are visible to end-users: no
Test plan
bazel test //cases/pytest-mock-530:test_mock_py_testandbazel test //cases/pytest-mock-530:test_mock_py_venv_testpass, exercising themockerfixture,mocker.spy, andMagicMock