tweak(sdist_configure): suppress setup.py stdout/stderr unless eval fails#888
Merged
tweak(sdist_configure): suppress setup.py stdout/stderr unless eval fails#888
Conversation
Redirect stdout/stderr to temporary files during setup.py exec() so stray print() calls don't corrupt the JSON output on stdout. The captured output is only replayed to stderr if the evaluation fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
arrdem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirect stdout/stderr to temporary files during
_parse_setup_py_requires'sexec()so strayprint()calls from evaluated setup.py files don't corrupt the JSON output on stdout. Captured output is replayed to stderr only when the evaluation fails, preserving debuggability.cc @zbarsky-openai
Changes are visible to end-users: no
Test plan
🤖 Generated with Claude Code