fix(uv): fix evaluation of PEP 508 specs involving nested parentheses#901
fix(uv): fix evaluation of PEP 508 specs involving nested parentheses#901jbedard merged 1 commit intoaspect-build:mainfrom
Conversation
|
|
@xangcastle I was wondering if you could take a look at this PR when you have a chance? I'm not sure what the CI error is about but it looks like it's not related to my change. |
See issues on PRs that come from forks such as #901 ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases
|
If you rebase the CI error should be gone now |
See issues on PRs that come from forks such as #901 ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases
See issues on PRs that come from forks such as #901 ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases
This change fixes two bugs in pep508_evaluate.bzl: - `_new_expr` used `_current[0]` (outermost) instead of `_current[-1]` (innermost) when resolving the active sub-expression, causing values inside nested parens to land in the wrong expression node - There was a typo of `current.tree._append(value)` instead of `current.tree.append(value)`. This change also adds a Starlark unit test suite for the evaluate function. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
I gave that a try but it's still not working unfortunately. I see it's trying to fetch something involving |

This change fixes two bugs in pep508_evaluate.bzl:
_new_exprused_current[0](outermost) instead of_current[-1](innermost) when resolving the active sub-expression, causing values inside nested parens to land in the wrong expression nodecurrent.tree._append(value)instead ofcurrent.tree.append(value).This change also adds a Starlark unit test suite for the evaluate function.
Changes are visible to end-users: yes
Test plan