This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Application insights logger lightup #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Apr 27, 2017
| { | ||
| if (item is TraceTelemetry traceTelemetry) | ||
| { | ||
| HttpResponseWritingExtensions.WriteAsync(_response, traceTelemetry.Message + Environment.NewLine).GetAwaiter().GetResult(); |
| return builder => | ||
| { | ||
| var loggerFactory = builder.ApplicationServices.GetService<ILoggerFactory>(); | ||
| // We need to disable filter on logger, filtering would be done by LoggerFactory |
| private static void ConfigureLogging(IConfigurationBuilder configurationBuilder) | ||
| { | ||
| // Skip adding default rules when debugger is attached | ||
| // we want to sent all events to VS |
| { | ||
| return _defaultLoggingLevels.Select(pair => | ||
| { | ||
| var key = $"Logging:{ApplicationInsightsLoggerFactory}:LogLevel:{pair.Key}"; |
Member
There was a problem hiding this comment.
Why did you extract just this part of the string as a constant when it's not used elsewhere?
Contributor
Author
There was a problem hiding this comment.
Mostly because it was just too long
| { | ||
| var loggerFactory = builder.ApplicationServices.GetService<ILoggerFactory>(); | ||
| // We need to disable filter on logger, filtering would be done by LoggerFactory | ||
| loggerFactory.AddApplicationInsights(builder.ApplicationServices, (s, level) => true); |
Member
There was a problem hiding this comment.
Can't you use the simpler LogLevel.Trace overload?
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.ApplicationInsights.AspNetCore" Version="$(AppInsightsVersion)" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Hosting.Abstractions" Version="$(AspNetCoreVersion)" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging" Version="$(AspNetCoreVersion)" /> |
| public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory, IServiceProvider serviceProvider) | ||
| { | ||
| loggerfactory.AddConsole(LogLevel.Debug); | ||
| loggerFactory.AddConsole(LogLevel.Debug); |
Member
There was a problem hiding this comment.
This is going to be a warning when I push aspnet/Logging#605
muratg
approved these changes
Apr 27, 2017
muratg
left a comment
muratg
left a comment
There was a problem hiding this comment.
Approved, but check with @BrennanConroy WRT to his logging changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #26