Obsolete old APIs #605
Obsolete old APIs #605
Conversation
|
Awesome, it's great to see this! Small nitpick: There's a Visual Studio Version downgrade in the sln file. |
|
|
||
| /// <summary> | ||
| /// <para> | ||
| /// This method is being removed from the ILoggerFactory abstraction, to have similar behavior |
There was a problem hiding this comment.
Recommend following a pattern closer to the guidelines: https://github.com/aspnet/Home/wiki/Engineering-guidelines#breaking-changes
| /// Adds an <see cref="ILoggerProvider"/> to the logging system. | ||
| /// </summary> | ||
| /// <param name="provider">The <see cref="ILoggerProvider"/>.</param> | ||
| [Obsolete("This method is being removed from the ILoggerFactory abstraction, to have similar behavior" + |
|
|
||
| /// <summary> | ||
| /// <para> | ||
| /// This method is obsolete, use AddProvider on the concrete Microsoft.Extensions.Logging.LoggerFactory class. |
There was a problem hiding this comment.
Can we follow the guidelines on Recommend following a pattern closer to the guidelines: https://github.com/aspnet/Home/wiki/Engineering-guidelines#breaking-changes a little more closely? I recommend using the exact phrasing in there, i.e. This method is obsolete and will be removed in a future version. The recommended alternative is Microsoft.Extensions.Logging.LoggerFactory.AddProvider().
There was a problem hiding this comment.
(Applies to all the obsoletions in this PR.)
There was a problem hiding this comment.
This method is obsolete and will be removed in a future version. The recommended alternative is Microsoft.Extensions.Logging.AddConsole() on Microsoft.Extensions.Logging.LoggerFactory.
There was a problem hiding this comment.
This method is obsolete and will be removed in a future version. The recommended alternative is to call the Microsoft.Extensions.Logging.AddConsole() extension method on the Microsoft.Extensions.Logging.LoggerFactory instance.
Eilon
left a comment
Eilon
left a comment
There was a problem hiding this comment.
Looks good! Can you log a new bug that says to actually delete all these obsolete methods in a future version?
BrennanConroy
force-pushed
the
brecon/obsolete
branch
from
0f5c64b to
dc151a1
Compare
BrennanConroy
force-pushed
the
brecon/obsolete
branch
from
dc151a1 to
e148579
Compare
No description provided.