ConfigurationBinder to support more property types

[MichaCo]

Currently the ConfigurationBinder supports only the base types and Enums.

How about adding

• Type: Expressed as string, e.g. "System.String" or "System.String, System" to include the assembly
• TimeSpan: Commonly used for timeout properties. Expressed as string: "356.23:59:59.999999" which can be parsed via TimeSpan.Parse
• DateTimeOffset?

Note: There was a similar feature tracked on the Options repo: aspnet/Options#29, now the binder lives in here in Configuration ;)

[davidfowl]

Type: Expressed as string, e.g. "System.String" or "System.String, System" to include the assembly

Not a fan for this one as it requires potentially loading an assembly which can go wrong in some ways.

The others seem fine and you should totally send a pull request 😄

[MichaCo]

@davidfowl Hi David, I sent a PR for that few days ago, enjoy ;)

One question, not related to this:
I'm working on a German Windows and when running certain unit tests from different aspnet or dotnet repositories, the tests are failing because there are checks against e.g. exception messages. But those are localized, meaning, I'm getting different results ;)
If I remember correctly, in the old asp.net MVC project you guys had a switch culture attribute on each fact and set the culture to en-GB to prevent this.

Is this a thing for you or do we just ignore it?

It is pretty minor in general, although the failing tests in System.Globalization.Extensions worries me a little bit ^^

[dougbu]

@MichaCo the Microsoft.AspNet.Testing package contains both a [ReplaceCulture] attribute and a CultureReplacer class useful within narrow using blocks. Tests in the Configuration repo do not currently use either. Correcting the ones that fail when using German Windows would be a useful separate PR...

[HaoK]

3476fad