Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Conversation

@kirthik
Copy link
Contributor

@kirthik kirthik commented Sep 14, 2015

cc @divega

NuGet.Config Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this file in next iteration.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidfowl
Copy link
Member

What will this break?

@divega
Copy link

divega commented Sep 15, 2015

@davidfowl It reverts a break we inadvertently had late in beta7. From #279:

  1. We will go back to the previous behavior of Key: configuration.GetSection("A:B").Key == "B"
  2. We will add a Path property: configuration.GetSection("A:B").Path == "A:B"
  3. We need to make sure that on the API calls on a given node we honor the prefix that applies to it: configuration.GetSection("A").GetSection("B").Path == "A:B"

Last time we made a few changes to other repos to react to configuration changes (which were bigger than this). We will have to look around again to those changes in case we added code that depends on the beta7 behavior.

@kirthik
Copy link
Contributor Author

kirthik commented Sep 17, 2015

cc @divega : updated PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed fine to call this one and assign it to a variable in the beginning. It saves unnecessary method calls.

@kirthik
Copy link
Contributor Author

kirthik commented Sep 18, 2015

@Eilon ya :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use Path to get any behavior in derived types.

@kirthik
Copy link
Contributor Author

kirthik commented Sep 21, 2015

cc @divega - updated

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: parentPath + delimiter is really the prefix 😄

@divega
Copy link

divega commented Sep 21, 2015

:shipit:

@hishamco
Copy link
Contributor

According to 57e808b this must be closed

@kirthik
Copy link
Contributor Author

kirthik commented Sep 22, 2015

merged 57e808b

@kirthik kirthik closed this Sep 22, 2015
@natemcmaster natemcmaster deleted the fix279 branch June 12, 2017 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants