-
Notifications
You must be signed in to change notification settings - Fork 200
Conversation
NuGet.Config
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove this file in next iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
What will this break? |
|
@davidfowl It reverts a break we inadvertently had late in beta7. From #279:
Last time we made a few changes to other repos to react to configuration changes (which were bigger than this). We will have to look around again to those changes in case we added code that depends on the beta7 behavior. |
|
cc @divega : updated PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed fine to call this one and assign it to a variable in the beginning. It saves unnecessary method calls.
|
@Eilon ya :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use Path to get any behavior in derived types.
|
cc @divega - updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: parentPath + delimiter is really the prefix 😄
|
|
|
According to 57e808b this must be closed |
|
merged 57e808b |
cc @divega