Poor log message when trying to connect with https to an http endpoint

[Tratcher]

If someone sends an https request to an http endpoint it fails as expected, but the log message does not help them understand why: "No space character found after method in request line."

This was found when a site had a redirect to https rule but the site had not yet set up https.

Proposal: If the request line fails to parse consider checking if it has the format of an SSL/TLS handshake and provide a more specific error like 'An invalid SSL/TLS handshake was attempted on an HTTP endpoint."

@mikaelm12 @muratg @danroth27

[davidfowl]

Yea I don't think we should do this as annoying as that error message is. What do other servers do?

[cesarblum]

This should be a matter of checking if the first byte in the request is 0x16. Or am I missing something?

[Tratcher]

Something like that, but it may vary across versions.

[mikeharder]

Is there an RFC which specifies that the first byte of an HTTPS request will be 0x16?

[cesarblum]

https://tools.ietf.org/html/rfc5246#section-6.2.1 (thanks @Tratcher)

[khellang]

Or, a more visual breakdown of the handshake TLS record; https://en.wikipedia.org/wiki/Transport_Layer_Security#Handshake_protocol

[Tratcher]

RFC links make good code comments