Kestrel doesn't log now listening on correctly for https

[JunTaoLuo]

I configured the basic middleware RewriteSample with

var host = new WebHostBuilder()
                .UseKestrel(options =>
                {
                    options.Listen(IPAddress.Loopback, 5000);
                    options.Listen(IPAddress.Loopback, 5001, listenOptions =>
                    {
                        listenOptions.UseHttps("testCert.pfx", "testPassword");
                    });
                })

When I run the sample I see the output:

Hosting environment: Production
Content root path: C:\gh\BasicMiddleware\samples\RewriteSample
Now listening on: http://127.0.0.1:5000
Now listening on: http://127.0.0.1:5001
Application started. Press Ctrl+C to shut down.

the https url should be https://127.0.0.1:5001

[muratg]

@natemcmaster please ping @halter73 before you start looking into this.

[natemcmaster]

Related work:

aspnet/Hosting#968
#1519
#1495

[cesarblum]

Given #1519, I think you can close this. <- 💩

Problem is if you do

.UseKestrel(options =>
{
    options.Listen(IPAddress.Loopback, 5001, listenOptions =>
    {
        listenOptions.UseHttps("testCert.pfx", "testPassword");
        listenOptions.UseConnectionLogging();
    });
})

You still see this in the console:

Now listening on: http://127.0.0.1:5001

[natemcmaster]

I've already forgotten what we decided to do here. Was there going to be a new field on IServerAddressesFeature for scheme that Kestrel can set when appropriate? cc @JunTaoLuo @Tratcher

[Tratcher]

None of the design changes we discussed affect this issue, nor does #1519.

    options.Listen(IPAddress.Loopback, 5001, listenOptions =>
    {
        listenOptions.UseHttps("testCert.pfx", "testPassword");
        listenOptions.UseConnectionLogging();
    });

Should result in IServerAddressesFeature values being replaced with "https://127.0.0.1:5001/".
(unless IServerAddressesFeature has the new PreferHostingConfig option enabled, in which case you ignore Listen).

[natemcmaster]

Took a look at this again. Here are two options

The simple one
Make ListenOptions.Scheme public & settable. UseHttps overloads set options.Scheme = "https".

The make-an-abstraction one
Something like

public interface IServerAddressProvider
{
   // DisplayName = trying to communicate that the value is only used in console output or loggers
   string GetServerAddressDisplayName();
}

KestrelServer.Start would

1. check any ListenOptions.ConnectionAdapters that also implements IServerAddressProvider. Last one wins.
2. If none found, fallback to ListenOptions.ToString

cc @davidfowl