Address cross-project contamination when restoring in VS #801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the restore-on-save operation, we were using a cached instance of the "before" manifest, which was used to clean up file deltas. A side effect of this was that we used the working folder for that cached manifest. If the user makes changes to a second libman.json, then it cleans the delta between that file and the previous libman.json in its folder. That typically would appear as deleting the files out of one project when making changes the libman.json file in a different project. The fix is straightforward: cache the instance in a per-document form instead of a single stored value.
dbreshears
approved these changes
Oct 14, 2025
Member
|
/azp run |
|
Commenter does not have sufficient privileges for PR 801 in repo aspnet/LibraryManager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the restore-on-save operation, we were using a cached instance of the "before" manifest, which was used to clean up file deltas. A side effect of this was that we used the working folder for that cached manifest.
If the user makes changes to a second libman.json, then it cleans the delta between that file and the previous libman.json in its folder. That typically would appear as deleting the files out of one project when making changes the libman.json file in a different project.
The fix is straightforward: cache the instance in a per-document form instead of a single stored value.
Resolves #800