Get segment from mapped route for CustomRequestCultureProvider

[Codenator81]

I tested after

app.UseMvc(routes =>

in startup class app.UseRequestLocalization not work.
For example user want culture segment been in:

routes.MapRoute(
                    name: "transRoute",
                    template: "{controller=Home}/{culture=en-US}/{action=Index}/{id?}");

So how I can get {culture} segment to find route match?

This is all way not processed:

options.RequestCultureProviders.Insert(0, new CustomRequestCultureProvider(async context =>
            {
                var routeContext = new RouteContext(context); // IsHandled all ways false

Thanks Alex

[BenjiZombie]

What I did was create a RouteRequestCultureProvider instead.

namespace Microsoft.AspNet.Localization
{
    /// <summary>
    /// Determines the culture information for a request via values in the route.
    /// </summary>
    public class RouteRequestCultureProvider : RequestCultureProvider
    {
        #region Overrides of RequestCultureProvider

        public override Task<RequestCulture> DetermineRequestCulture(HttpContext httpContext)
        {
            if (httpContext == null)
            {
                throw new ArgumentNullException(nameof(httpContext));
            }

            var request = httpContext.Request;
            if (!request.Path.HasValue)
            {
                return Task.FromResult((RequestCulture) null);
            }

            var cultureValue = Regex.Match(
                request.Path.Value,
                @"^/([a-z]{2})",
                RegexOptions.IgnoreCase);

            if (cultureValue.Success)
            {
                var culture = CultureInfoCache.GetCultureInfo(cultureValue.Groups[1].Value);
                var uiCulture = CultureInfoCache.GetCultureInfo(cultureValue.Groups[1].Value);

                if (culture == null || uiCulture == null)
                {
                    return Task.FromResult((RequestCulture) null);
                }

                var requestCulture = new RequestCulture(culture, uiCulture);
                requestCulture = ValidateRequestCulture(requestCulture);

                return Task.FromResult(requestCulture);
            }

            return Task.FromResult((RequestCulture) null);
        }

        #endregion
    }
}

Then simply register it in the Configure method:

// Add localization to the request pipeline.
var requestLocalizationOptions = new RequestLocalizationOptions
{
    SupportedCultures = new List<CultureInfo>
    {
        new CultureInfo("en"),
        new CultureInfo("fr"),
        new CultureInfo("es")
    },
    SupportedUICultures = new List<CultureInfo>
    {
        new CultureInfo("en"),
        new CultureInfo("fr"),
        new CultureInfo("es")
    }
};
requestLocalizationOptions.RequestCultureProviders.Insert(2, new RouteRequestCultureProvider
{
    Options = requestLocalizationOptions
});
app.UseRequestLocalization(requestLocalizationOptions);

My route mapping is different from yours, but you can easily modify the code to fit your needs

// Add MVC to the request pipeline.
app.UseMvc(routes =>
{
    routes.MapRoute(
        name: "default",
        template: "{culture?}/{controller}/{action}/{id?}",
        defaults: new { culture = "en", controller = "Home", action = "Index" });
});

[Codenator81]

@BenjiZombie thanks for good example.
I do similar in my code https://github.com/WeebDo/WeebDo.CMF/blob/master/src/WeebDoCMF/Startup.cs#L190
I think there no way to get segment {culture} from route for now before

app.UseMvc(routes =>
{
    routes.MapRoute(
        name: "default",
        template: "{culture?}/{controller}/{action}/{id?}",
        defaults: new { culture = "en", controller = "Home", action = "Index" });
});

[hishamco]

You can have a look to issue #54 #57 as well as https://github.com/aspnet/Localization/blob/dev/test/Microsoft.AspNet.Localization.Tests/CustomRequestCultureProviderTest.cs#L46

[Codenator81]

@hishamco Thanks I implement my code based on your links 👍
Here question more about how get culture as I do in MVC 5 from Controller

RouteData.Values["culture"] as string;

[hishamco]

@Codenator81 you can inject IHtmlLocalizer in your controller constructor, have a look to @damienbod source here https://github.com/damienbod/AspNet5Localization/blob/master/AspNet5Localization/src/AspNet5Localization/Controllers/AboutController.cs#L16

[Codenator81]

@hishamco I do it in HomeController all ready)
https://github.com/WeebDo/WeebDo.CMF/blob/master/src/WeebDoCMF/Controllers/HomeController.cs#L19

[hishamco]

What is the value of ViewBag.Trans when you print it out, because I don't know what is the issue in your sample

[Codenator81]

@hishamco There everything work great. My issue is how get route segment from route template before UseMVC middleware. But I think it is not possible. I will try different approach.

[hishamco]

Why you need it before MVC middleware?!! if that's the case i will try to look in your sample

[Codenator81]

@hishamco You are right 👍
I will write own middleware which going to work after UseMVC and set needed culture thread

[hishamco]

All the best @Codenator81 , be free to ask if you have an issue again

[danroth27]

@kirthik @DamianEdwards We should look at what our guidance is for using path segments for determining the culture and maybe provide a sample on how to do it.

[hishamco]

@danroth27 i provide a simple unit test in https://github.com/aspnet/Localization/blob/dev/test/Microsoft.AspNet.Localization.Tests/CustomRequestCultureProviderTest.cs#L46, also I already suggest #43, if this will help i will make a PR for that

[Codenator81]

Middlewares don`t work after UseMVC middleware

[hishamco]

@Codenator81 if what you are looking for is in culture segment in "{controller=Home}/{culture=en-US}/{action=Index}/{id?}", I will try to look to into your sample or i will write a code snippet to display the culture segment