Issue #59: Updated JSON source where dictionary does not contain currentSection name#60
Closed
chriswill wants to merge 1 commit intoaspnet:masterfrom
chriswill:master
Closed
Issue #59: Updated JSON source where dictionary does not contain currentSection name#60chriswill wants to merge 1 commit intoaspnet:masterfrom chriswill:master
chriswill wants to merge 1 commit intoaspnet:masterfrom
chriswill:master
Conversation
…t defined in the settings dictionary.
chriswill
changed the title
twsouthwick
reviewed
Jun 4, 2019
| Dictionary<string, string> d = _allSettings[_currentSection]; | ||
| return d ?? _allSettings[""]; | ||
| { | ||
| if (_allSettings.ContainsKey(_currentSection)) |
Contributor
There was a problem hiding this comment.
better to use TryGetValue
| { | ||
| if (_allSettings.ContainsKey(_currentSection)) | ||
| { | ||
| d = _allSettings[_currentSection]; |
Contributor
There was a problem hiding this comment.
Could you just return the value (since it was retrieved)?
Collaborator
|
This has been fixed by #67. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is discussed in #59