Skip to content

Adding the ability to define a custom (local) path to Roslyn (#25)#26

Merged
HongGit merged 3 commits intoaspnet:masterfrom
Lombiq:issue/25
Mar 9, 2018
Merged

Adding the ability to define a custom (local) path to Roslyn (#25)#26
HongGit merged 3 commits intoaspnet:masterfrom
Lombiq:issue/25

Conversation

@BenedekFarkas
Copy link
Copy Markdown
Contributor

#25

@HongGit HongGit merged commit e79aa12 into aspnet:master Mar 9, 2018
Jinhuafei added a commit that referenced this pull request Mar 9, 2018
HongGit pushed a commit that referenced this pull request Mar 9, 2018
…25)" (#34)

* Revert "add support for non web proj (#32)"

This reverts commit b9e1127.

* Revert "include commit link (#31)"

This reverts commit 30f97fb.

* Revert "Adding the ability to define a custom (local) path to Roslyn (#25) (#26)"

This reverts commit e79aa12.
@Jinhuafei
Copy link
Copy Markdown
Contributor

This was accidentally merged. The similar function was added in PR 36 and you can set the compiler location through appsetting aspnet:RoslynCompilerLocation.

We used appsetting instead of compiler parameters, because 1. the compiler location is not a compiler parameter. 2. the setting is consistent with the other codedom provider setting which also uses appsetting

@BenedekFarkas
Copy link
Copy Markdown
Contributor Author

OK, thanks, I'll check it out and get back to you after testing my scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants