Conversation
HongGit
reviewed
Aug 28, 2018
| catch (Exception ex) | ||
| { | ||
| Log.LogErrorFromException(ex); | ||
| Log.LogWarning(ex.Message); |
Contributor
There was a problem hiding this comment.
Why switching this to warning from error? Isn't this suppose to be exception message?
Contributor
Author
There was a problem hiding this comment.
Error will cause build failure, while warning not necessarily will. The code here is to reduce the chance of copying Roslyn bits failure. If there is any exception, just log a warning which may not cause build failure.
HongGit
approved these changes
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address the issue #52