This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Prefer StringComparison over StringComparer when not using comparers #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The code change seem fine, but I've read that post over a few times and I still don't get it. How does this make user's lives better? Does this more perf? |
Member
Author
|
There is no real benefit, it's just StringComparer is for cases when an API uses IComparer, e.g. the Dictionary comparer, and StringComparison is for regular string comparisons. |
rynowak
approved these changes
Oct 17, 2018
Member
|
Ok - you get an approve because its clearer? I guess? |
Member
Author
|
You have forgotten the most valuable thing of all: 1 James point |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stackoverflow.com/a/8918112/11829