Consolidate UseStaticFiles/UseFileServer into a single method

[DamianEdwards]

It should be a single method with options.

[Tratcher]

These components are not the same thing. Is this more about naming confusion?

[davidfowl]

The funny thing is, its the same middleware with different extension methods. Can you outside the specific differences so we can come up with a better name?

EDIT: outside -> outline

[Tratcher]

public static IApplicationBuilder UseStaticFiles([NotNull] this IApplicationBuilder builder, [NotNull] StaticFileOptions options)
{
  return builder.UseMiddleware<StaticFileMiddleware>(options);
}

vs:

public static IApplicationBuilder UseFileServer([NotNull] this IApplicationBuilder builder, [NotNull] FileServerOptions options)
{
  if (options.EnableDefaultFiles) // true by default
  {
    builder = builder.UseDefaultFiles(options.DefaultFilesOptions);
  }
  if (options.EnableDirectoryBrowsing) // false by default
  {
    builder = builder.UseDirectoryBrowser(options.DirectoryBrowserOptions);
  }
  return builder.UseSendFileFallback().UseStaticFiles(options.StaticFileOptions);
}

[davidfowl]

I meant, can you explain the functional differences? I can see the code but what makes it impossible to use a single method with options?

[Tratcher]

Everyone could use UseFileServer, but it makes the primary scenario of just serving static files more complex. Directory browsing and default files are much less common scenarios, so we shouldn't list them together with the primary static file scenario.

Consider the code required to set any static file serving options:

            app.UseStaticFiles(new StaticFileOptions()
            {
                ServeUnknownFileTypes = true,
                DefaultContentType = "text/plain"
            });

vs.

            var fileServerOptions = new FileServerOptions();
            fileServerOptions.EnableDefaultFiles = false;
            fileServerOptions.StaticFileOptions.ServeUnknownFileTypes = true;
            fileServerOptions.StaticFileOptions.DefaultContentType = "text/plain";
            app.UseFileServer(fileServerOptions);

[borgdylan]

I switched from static files to file server just because only the latter allows me to enable directory browsing. If static files allowed this it might be easier to make them into one set of extensions.

[Bartmax]

Doesn't removing the StaticFileOptions makes it configure with something like

app.UseFileServer(new FileServerOptions()
{
    EnableDefaultFiles = false,
    ServeUnknownFileTypes = true,
    DefaultContentType = "text/plain"
});

That looks better than having 2 extension imho.

[muratg]

Putting this in RC2 for now. We'll need to discuss the design, and can potentially punt this.

[muratg]

Wasn't designed. Moving this to Backlog as we will be in RC2 ask mode very soon. If you feel strongly about this issue, please ping me.