-
Notifications
You must be signed in to change notification settings - Fork 167
Add Dockerfiles for CoreCLR-1.0.0-beta5-11624 and PartsUnlimited Demo #51
Conversation
|
Hi @jeremymeng, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
TTYL, MSOTBOT; |
coreclr-1.0.0-beta5-11624/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better name for the tag is welcome
|
@jeremymeng tag sounds ok. Can you please exclude PartsUnlimited, it shouldnt go to this repo. Also please don't add anything to the readme or just "edit" the readme that's under beta3/README.md. We follow a symlink trick for readme to show up on Docker Hub. |
|
LGTM thanks @jeremymeng |
Add Dockerfiles for CoreCLR-1.0.0-beta5-11624 and PartsUnlimited Demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These builds come & go every day... within a few days that build will be gone. I can pin builds on MyGet... any particular build you want? This one? A newer one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremymeng @MattGal ^ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need to be specific? Is this just for the parts unlimited demo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok I can certainly pin it but I wonder what else would need to be pinned. Pinning just one DNX package is easy. But for example we're embarking on another big round of renames and so finding compatible packages will be difficult because other packages that rev will eventually stop working with this DNX. It's not feasible for us to find a graph of ~200 packages and pinning them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eilon Please pin this build. It has been tested for the PartsUnlimited app. If needed we could add another one for coreclr-nightly.
@davidfowl Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We saved a published PartsUnlimited app with its dependencies. So I think that will continue to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the full closure of what's needed then you're fine for whoever uses the exact snapshot. But this Docker image as it is currently configured will eventually cease to be useful (in a few days, possibly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this with @ahmetalpbalkan, and I believe (Ahmet please correct me if wrong) that unless something changes that results in re-generating the image produced by this dockerfile, the resultant image will stay the same (and thus not need to fetch dependencies) unless someone triggers an update for it. My understanding was that given the runtime is already on the docker image used and all dependencies are in the tar.gz, the only way that we would break this setup from working would be if you unpinned the 11624 DNX and then someone regenerated the coreclr-1.0.0-beta5-11624 image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK... if you're confident it's fine then I'm fine with that 😄 Worst case if something goes awry we can regenerate everything with a newer build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy where this landed. As @MattGal says, the PartsUnlimited app we are handing out has all its dependencies, so we shouldn't have to hit myget for the main use case for this image.
No description provided.