This repository was archived by the owner on May 31, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 167
Add Dockerfiles for CoreCLR-1.0.0-beta5-11624 and PartsUnlimited Demo #51
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7d30af3
Add Dockerfiles for CoreCLR-1.0.0-beta5-11624 and PartsUnlimited Demo…
voidfoo a81fa12
Remove README.md and the demo Dockerfile.
voidfoo ba294e4
Remove inaccurate comment.
voidfoo f74ff19
Add coreclr-1.0.0-beta5-11624 to README.md.
voidfoo a02c2ec
Remove the extra '+'.
voidfoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| FROM ubuntu:14.04 | ||
|
|
||
| ENV DNX_FEED https://www.myget.org/F/aspnetvnext/api/v2 | ||
|
|
||
| RUN apt-get update -qq \ | ||
| && apt-get install -qqy libunwind8 libssl-dev curl unzip libtool automake build-essential | ||
|
|
||
| # Install libuv for Kestrel from source code (binary is not in wheezy and one in jessie is still too old) | ||
| RUN LIBUV_VERSION=1.4.2 \ | ||
| && curl -sSL https://github.com/libuv/libuv/archive/v${LIBUV_VERSION}.tar.gz | tar zxfv - -C /usr/local/src \ | ||
| && cd /usr/local/src/libuv-$LIBUV_VERSION \ | ||
| && sh autogen.sh && ./configure && make && make install \ | ||
| && rm -rf /usr/local/src/libuv-$LIBUV_VERSION \ | ||
| && ldconfig | ||
|
|
||
| RUN curl -sSL https://raw.githubusercontent.com/aspnet/Home/dev/dnvminstall.sh | DNX_BRANCH=dev sh \ | ||
| && bash -c "source $HOME/.dnx/dnvm/dnvm.sh \ | ||
| && dnvm install 1.0.0-beta5-11624 -r coreclr -arch x64 -a default \ | ||
| && ln -s $HOME/.dnx/runtimes/dnx-coreclr-linux-x64.1.0.0-beta5-11624 $HOME/.dnx/runtimes/default" | ||
|
|
||
| ENV PATH $PATH:/root/.dnx/runtimes/default/bin | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These builds come & go every day... within a few days that build will be gone. I can pin builds on MyGet... any particular build you want? This one? A newer one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremymeng @MattGal ^ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it need to be specific? Is this just for the parts unlimited demo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok I can certainly pin it but I wonder what else would need to be pinned. Pinning just one DNX package is easy. But for example we're embarking on another big round of renames and so finding compatible packages will be difficult because other packages that rev will eventually stop working with this DNX. It's not feasible for us to find a graph of ~200 packages and pinning them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eilon Please pin this build. It has been tested for the PartsUnlimited app. If needed we could add another one for
coreclr-nightly.@davidfowl Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We saved a published PartsUnlimited app with its dependencies. So I think that will continue to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have the full closure of what's needed then you're fine for whoever uses the exact snapshot. But this Docker image as it is currently configured will eventually cease to be useful (in a few days, possibly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this with @ahmetalpbalkan, and I believe (Ahmet please correct me if wrong) that unless something changes that results in re-generating the image produced by this dockerfile, the resultant image will stay the same (and thus not need to fetch dependencies) unless someone triggers an update for it. My understanding was that given the runtime is already on the docker image used and all dependencies are in the tar.gz, the only way that we would break this setup from working would be if you unpinned the 11624 DNX and then someone regenerated the coreclr-1.0.0-beta5-11624 image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK... if you're confident it's fine then I'm fine with that 😄 Worst case if something goes awry we can regenerate everything with a newer build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy where this landed. As @MattGal says, the PartsUnlimited app we are handing out has all its dependencies, so we shouldn't have to hit myget for the main use case for this image.