-
Notifications
You must be signed in to change notification settings - Fork 167
Use mono 4.0.1 instead of mono 4.1.0 according to aspnet/home, change vs... #56
Conversation
|
Hi @yanchenw, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution! TTYL, MSOTBOT; |
|
@yanchenw thanks for the PR! I will hold off until this PR until mono:4.1.0 is tagged on Docker Hub if there's no urgent need? |
|
Should be OK. Any idea when mono 4.1.0 will be tagged? |
|
@yanchenw nope but once it appears at https://github.com/mono/mono/tags it'll probably take a day or so. |
|
Mono 4.1 (like all odd subversions) is the "in development" version and typically won't receive a tag. |
|
@akoeplinger Oh, I didn't know that convention. It is apparently case with mono Docker images as well: https://registry.hub.docker.com/u/library/mono/ I guess we could still use 4.1.0 release by doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no need for this folder anymore.
I will make this point to 1.0.0-beta4 folder on Docker Hub settings once merged and 1.0.0-beta4 and vs-1.0.0-beta4 will be the same image that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
4.1 will never be in the repositories, it'll be declared 4.2 once it's "stable". |
|
@akoeplinger ok I was deceived by the |
according to aspnet/home, remove vs-1.0.0-beta4 since it should points to official 1.0.0-beta4 image now.
|
@yanchenw thanks for the change. Merging assuming you tested the product that uses the vs-* image. |
|
Waiving CLA since @yanchenw is a MSFT employee (he's registering himself to the CLA system now). |
Use mono 4.0.1 instead of mono 4.1.0 in beta4
Use mono 4.0.1 instead of mono 4.1.0 as aspnet/home suggested:
https://github.com/aspnet/Home/blob/dev/GettingStartedDeb.md
Change vs-1.0.0-beta4 to based on official aspnet:1.0.0-beta4 to keep them consistent.