Skip to content
This repository was archived by the owner on May 31, 2019. It is now read-only.

Conversation

@peterj
Copy link

@peterj peterj commented Aug 25, 2015

Adding Dockerfile for beta7.

@dnfclas
Copy link

dnfclas commented Aug 25, 2015

Hi @PeterJausovec, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Aug 25, 2015

@PeterJausovec, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@ahmetb
Copy link
Contributor

ahmetb commented Aug 25, 2015

CI is failing:

Error: Could not find version 1.0.0-beta7 in feed https://www.nuget.org/api/v2

@glennc
Copy link
Member

glennc commented Aug 26, 2015

That would be because we haven't pushed a beta7 DNX to NuGet yet. We are supposed to ship it to NuGet on Monday, so we can wait until then and re-run the tests before merging?

@ahmetb
Copy link
Contributor

ahmetb commented Aug 26, 2015

@glennc thanks for the update. The change is LGTM, feel free to rebuild on circleCI when it's pushed and merge if the build passes.

@ahmetb
Copy link
Contributor

ahmetb commented Sep 2, 2015

@glennc thanks for triggering the CI. However it looks like beta7 is not tagged on Home repo. It fails on finding the samples

@glennc
Copy link
Member

glennc commented Sep 2, 2015

What are the requirements? There is a v1.0.0-beta7 tag. Do the tests run against latest samples on that tag?

@ahmetb
Copy link
Contributor

ahmetb commented Sep 2, 2015

@glennc Sent you email internally. beta7 tag does not have the samples/1.0.0-beta7 directory. The CI has been systematically looking for that in the past 6 versions ans this is 3rd time fixing the samples are being forgotten. We've been retagging the release in the past 3 times just b/c of this.

@glennc
Copy link
Member

glennc commented Sep 2, 2015

Yeah, I added the beta7 folder but the tag was created a while back. The samples are not forgotten, but they cannot be done until there is a build to test them with. Tag will be updated shortly and I will respin the CI.

@ahmetb
Copy link
Contributor

ahmetb commented Sep 2, 2015

@glennc Thanks.

@kichalla
Copy link
Member

kichalla commented Sep 2, 2015

@ahmetalpbalkan CI is failing as we no longer support dnx . kestrel (the dot part)...it should either be dnx kestrel(in which case its the current directory) or dnx -p <path-to-project.json> kestrel (with the -p or --project switch)..this is a Beta7 change to dnx.

https://github.com/aspnet/aspnet-docker/blob/master/.ci/build-app-image.sh#L26

I have already updated the Home repo samples to have this change, could we use those docker files instead?
https://github.com/aspnet/Home/blob/v1.0.0-beta7/samples/1.0.0-beta7/HelloWeb/Dockerfile#L9

@ahmetb
Copy link
Contributor

ahmetb commented Sep 2, 2015

@kichalla we should probably fix that CI script with some if clause like version > beta7 somehow. I'll try to take a look today...

However the error in the CI seemed a bit different to me, are we sure that's the error?:

image

@ahmetb
Copy link
Contributor

ahmetb commented Sep 2, 2015

could we use those docker files instead?

@kichalla sorry I misread your comment. Yes! we should use them if they are present. Let me see if I can send a fix and get Peter to rebase.

edit: opened #82 to fix this.

@ahmetb
Copy link
Contributor

ahmetb commented Sep 2, 2015

CI is messed up... Merging anyway to unblock. Thanks @PeterJausovec.

ahmetb added a commit that referenced this pull request Sep 2, 2015
@ahmetb ahmetb merged commit 0e9a1c8 into aspnet:master Sep 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants