-
Notifications
You must be signed in to change notification settings - Fork 167
Add beta7 #79
Add beta7 #79
Conversation
|
Hi @PeterJausovec, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@PeterJausovec, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
CI is failing:
|
|
That would be because we haven't pushed a beta7 DNX to NuGet yet. We are supposed to ship it to NuGet on Monday, so we can wait until then and re-run the tests before merging? |
|
@glennc thanks for the update. The change is LGTM, feel free to rebuild on circleCI when it's pushed and merge if the build passes. |
|
@glennc thanks for triggering the CI. However it looks like beta7 is not tagged on Home repo. It fails on finding the samples |
|
What are the requirements? There is a v1.0.0-beta7 tag. Do the tests run against latest samples on that tag? |
|
@glennc Sent you email internally. beta7 tag does not have the samples/1.0.0-beta7 directory. The CI has been systematically looking for that in the past 6 versions ans this is 3rd time fixing the samples are being forgotten. We've been retagging the release in the past 3 times just b/c of this. |
|
Yeah, I added the beta7 folder but the tag was created a while back. The samples are not forgotten, but they cannot be done until there is a build to test them with. Tag will be updated shortly and I will respin the CI. |
|
@glennc Thanks. |
|
@ahmetalpbalkan CI is failing as we no longer support https://github.com/aspnet/aspnet-docker/blob/master/.ci/build-app-image.sh#L26 I have already updated the Home repo samples to have this change, could we use those docker files instead? |
|
@kichalla we should probably fix that CI script with some if clause like However the error in the CI seemed a bit different to me, are we sure that's the error?: |
|
CI is messed up... Merging anyway to unblock. Thanks @PeterJausovec. |

Adding Dockerfile for beta7.