Use existing sample Dockerfiles in CI. Remove beta4 from CI #82
Conversation
There was a problem hiding this comment.
Since all the samples(including older beta versions with their own respective dnx . kestrel) in the home repo have their own Dockerfile, I think the we can modify this line to be dnx kestrel instead as going forward this is going to be the way to run.
There was a problem hiding this comment.
@kichalla problem is, if you actually checkout to 1.0.0-beta4 tag for instance, they don't have dockerfiles: https://github.com/aspnet/Home/tree/v1.0.0-beta4/samples/1.0.0-beta4 yet we build them in the CI as well...
So keeping this should be making sense as it injects dockerfiles to old versions where it has to be "dnx . kestrel"...
Maybe it's time for us to retire all those old versions (beta1-2-3-4) today and get going with the newer ones. This could clarify and make the CI scripts a lot precise.
|
CI is currently failing for beta4 (could be flakiness). |
|
Looks like in the beta4 (and possibly for the upper versions) the container starts (prints "Started") but exits immediately.... Investigating... |
|
|
|
CI failed again... I'm keeping adding debug stmts to see what's going wrong. Feel free to merge the open PR if you feel confident. |
|
Heh, worked this time dunno why. Excluding beta4 from the CI. |
ahmetb
changed the title
Use existing sample Dockerfiles in CI. Remove beta4 from CI
3 participants
Fixes the Dockerfile issue in PR #79's CI.
cc: @PeterJausovec @kichalla