Add a warning about keeping min.js up to date #44
Conversation
| function escapeAttributeValue(value) { | ||
| // As mentioned on http://api.jquery.com/category/selectors/ | ||
| return value.replace(/([!"#$%&'()*+,./:;<=>?@\[\\\]^`{|}~])/g, "\\\\$1"); | ||
| return value.replace(/([!"#$%&'()*+,./:;<=>?@\[\\\]^`{|}~])/g, "\\$1"); |
There was a problem hiding this comment.
And we're sure that reverting this line doesn't break anything? What was it trying to fix, and why did we think this fix was correct at the time?
There was a problem hiding this comment.
It was trying to fix #33. The actual problem there was what I commented a little bit ago, that his data-val-for was subtly wrong. My best bet for why we thought it was correct at the time is basically that I was testing the wrong stuff. I think I had hand-wrote his html into my test app and in doing so inadvertently fixed the typo, and my test app was probably also serving the un-updated *.min.js.
Lessons for me: 1. Always repro and fix in the same setup 2. As much as possible, verify that the code I changed is actually getting run.
|
|
ryanbrandenburg
force-pushed
the
rybrande/Build
branch
from
a0f77c3 to
d3fc3e7
Compare
|
|
||
| This project is part of ASP.NET Core. You can find samples, documentation and getting started instructions for ASP.NET Core at the [Home](https://github.com/aspnet/home) repo. | ||
|
|
||
| `jquery.validate.unobtrusive.min.js` must be kept up to date with `jquery.validate.unobtrusive.js`, this can easily be done by running `gulp` before commiting. |
Fixes #43. Added a warning about keeping min.js up to date, updated min.js and made gulp keep the license.