-
Notifications
You must be signed in to change notification settings - Fork 110
Add a warning about keeping min.js up to date #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
|
|
||
| function escapeAttributeValue(value) { | ||
| // As mentioned on http://api.jquery.com/category/selectors/ | ||
| return value.replace(/([!"#$%&'()*+,./:;<=>?@\[\\\]^`{|}~])/g, "\\\\$1"); | ||
| return value.replace(/([!"#$%&'()*+,./:;<=>?@\[\\\]^`{|}~])/g, "\\$1"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And we're sure that reverting this line doesn't break anything? What was it trying to fix, and why did we think this fix was correct at the time?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was trying to fix #33. The actual problem there was what I commented a little bit ago, that his data-val-for was subtly wrong. My best bet for why we thought it was correct at the time is basically that I was testing the wrong stuff. I think I had hand-wrote his html into my test app and in doing so inadvertently fixed the typo, and my test app was probably also serving the un-updated *.min.js. Lessons for me: 1. Always repro and fix in the same setup 2. As much as possible, verify that the code I changed is actually getting run.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Understood! |
||
| } | ||
|
|
||
| function getModelPrefix(fieldName) { | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
committing