Skip to content

Conversation

@lenardg
Copy link

@lenardg lenardg commented Jul 24, 2017

I added a new option to the regex validation to support regex options. I needed to add the case insensitive option.

The new options enables the developer to pass in RegExp options. For example:

data-val-regex="Please start your sentence with foo or end it with bar!" 
data-val-regex-pattern="^foo|bar$"
data-val-regex-flags="i" />

If no flags are specified, the code behaves like before (the flags parameter becomes undefined)

@ghost ghost removed the cla-not-required label Nov 14, 2017
@ghost ghost deleted a comment from dnfclas Nov 14, 2017
@mkArtakMSFT mkArtakMSFT requested a review from kichalla February 12, 2018 22:29
@mkArtakMSFT
Copy link
Contributor

Hi @lenardg. Thanks for your PR. One of our team members will look into this.

@mkArtakMSFT
Copy link
Contributor

@kichalla, can you please review this when you'll be back? Thanks!

@mkArtakMSFT mkArtakMSFT requested a review from javiercn May 15, 2018 18:38
@mkArtakMSFT
Copy link
Contributor

@javiercn, can you please review this? Thanks!

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't know how this will play with the equivalent .NET data annotation.

@lenardg
Copy link
Author

lenardg commented May 15, 2018

@javiercn The change is so that the new flags parameter is optional. So it should not need a change or interfere with the .NET data annotations in any way.

@danroth27 danroth27 added enhancement PRI: 3 - Optional Represents a low-priority issue. Handle if time allows. labels Oct 17, 2018
@danroth27 danroth27 added this to the 3.2.12 milestone Oct 17, 2018
@mkArtakMSFT
Copy link
Contributor

Thanks for your PR.
This repo is in maintenance-only mode, and we make only security or critical bug fixes.
Closing the PR as we do not plan to accept this any more.
Sorry that it took us so long to get back to you.

@mkArtakMSFT mkArtakMSFT closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRI: 3 - Optional Represents a low-priority issue. Handle if time allows.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants