Remove bower.json; add npm install exec; and fix version #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
approved these changes
Mar 13, 2018
Eilon
suggested changes
Mar 13, 2018
version.props
Outdated
| @@ -1 +1 @@ | |||
| 3.2.7 No newline at end of file | |||
| 3.2.8 No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Actually, wait, shouldn't we be on 3.2.9 now? We never should have released 3.2.8 at all.
Contributor
Author
There was a problem hiding this comment.
Should we release a 3.2.8 on NuGet at all then? Or re-do a release for both npm and NuGet?
Contributor
There was a problem hiding this comment.
Chatted in person. I think we should just "reset" and go to 3.2.9 at this point.
Eilon
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing bower.json file
Adding "npm install" to the msbuild file
3.2.7 has not been released yet. Reverting back to 3.2.7 since it was changed here #783.2.8 has already been released to npmcc @kichalla