Add required wrapper_options to input method#100
Merged
assembler merged 1 commit intoassembler:masterfrom May 11, 2015
Merged
Conversation
Simple Form gem now requires that any implementation of the input method now accepts a `wrapper_options` argument. The method definition without the argument is deprecated and will be removed in the next Simple Form version. This adds the required parameter and defaults it to an empty hash. Fixes assembler#99
|
Any word on merging this? All the deprecation errors in tests are very annoying. |
|
+1 plz. |
|
@assembler This is one click, zero work… what gives? Consider turning project maintenance over to someone else if you're not going to move on it. |
assembler
added a commit
that referenced
this pull request
May 11, 2015
Add required `wrapper_options` to input method
Owner
|
sorry about this. I've already turned the project over to cloudinary team. If anyone else is interested in moving the project forward, toss me a line, and I'll make you collaborator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple Form gem (as of 3.1.0) now requires that any implementation of the input
method now accepts a
wrapper_optionsargument. The method definitionwithout the argument is deprecated and will be removed in the next
Simple Form version. This adds the required parameter and defaults it
to an empty hash.
Fixes #99