Replace controller methods removed with Rails 4.2#117
Closed
vlado wants to merge 1 commit intoassembler:masterfrom
Closed
Replace controller methods removed with Rails 4.2#117vlado wants to merge 1 commit intoassembler:masterfrom
vlado wants to merge 1 commit intoassembler:masterfrom
Conversation
`respond_with` and class-Level `respond_to` are removed with Rails 4.2 so let's replace them with instance-level `respond_to` http://edgeguides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to
Author
|
Hi Milovan, I was using attachinary with Rails 4.2.4 application and I couldn't get it to work on heroku This should fix it by I was not able to run tests. Do you have some special setup for running tests? I get following error when I run ➜ attachinary git:(replace_deprecated_responders) ✗ rake
-------- ORM: active_record
/Users/vlado/.rbenv/versions/2.2.3/bin/ruby -I/Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib:/Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-support-3.3.0/lib /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
/Users/vlado/hubiC/Vlado/Code/attachinary/spec/features/notes_spec.rb:1:in `require': cannot load such file -- rails_helper (LoadError)
from /Users/vlado/hubiC/Vlado/Code/attachinary/spec/features/notes_spec.rb:1:in `<top (required)>'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1327:in `load'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1327:in `block in load_spec_files'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1325:in `each'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1325:in `load_spec_files'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:102:in `setup'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:88:in `run'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:73:in `run'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:41:in `invoke'
from /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/exe/rspec:4:in `<main>'
/Users/vlado/.rbenv/versions/2.2.3/bin/ruby -I/Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/lib:/Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-support-3.3.0/lib /Users/vlado/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/gems/rspec-core-3.3.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed
➜ attachinary git:(replace_deprecated_responders) ✗ |
Author
|
Damn, I see now that this is a duplicate #112 |
Closed
Collaborator
|
Closing in favor of #112 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
respond_withand class-levelrespond_toare removed with Rails 4.2so let's replace them with instance-level
respond_tohttp://edgeguides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to