Skip to content

Conversation

@ODiogoSilva
Copy link
Collaborator

@ODiogoSilva ODiogoSilva commented Oct 2, 2018

This PR adds the publishing of assembly graph results for assemblers that support this format:

  • spades
  • megahit

The results are are published under:

reports/assembly/spades_<pid>/<sample_id>
reports/assembly/megahit_<pid>/<sample_id>

@ODiogoSilva ODiogoSilva changed the base branch from master to dev October 2, 2018 23:15
@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #139 into dev will increase coverage by 0.84%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #139      +/-   ##
==========================================
+ Coverage   38.47%   39.31%   +0.84%     
==========================================
  Files          59       59              
  Lines        5588     6043     +455     
==========================================
+ Hits         2150     2376     +226     
- Misses       3438     3667     +229
Impacted Files Coverage Δ
flowcraft/generator/components/metagenomics.py 100% <100%> (ø) ⬆️
flowcraft/tests/test_pipeline_parser.py 100% <0%> (ø) ⬆️
flowcraft/generator/inspect.py 11.15% <0%> (+0.88%) ⬆️
flowcraft/generator/pipeline_parser.py 97.08% <0%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d00a9...16bcfb7. Read the comment docs.

toValidate_{{ pid }}.set{IN_fastg}
}

process megahit_fastg_{{ pid }}{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest putting the entire process conditional, thereby by-passing the creation of a new channel:

if (parans.fastq{{ param_id }}) {
    process megahit_fastg_{{ pid }}{
        // el code
    }
}

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! I'll add those changes :)

@ODiogoSilva ODiogoSilva merged commit d2e4899 into dev Oct 8, 2018
@ODiogoSilva ODiogoSilva deleted the assembly_graph branch October 8, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants